BufferedSink: Remove progress notifications#24
Merged
cboden merged 1 commit intoreactphp:masterfrom Jan 19, 2016
jsor:remove-progress-from-buffered-sink
Merged
BufferedSink: Remove progress notifications#24cboden merged 1 commit intoreactphp:masterfrom jsor:remove-progress-from-buffered-sink
cboden merged 1 commit intoreactphp:masterfrom
jsor:remove-progress-from-buffered-sink
Conversation
Member
|
LGTM 👍 && +1 |
Member
|
LGTM 👍 For the reference: See reactphp/promise#32 for some background |
cboden
added a commit
that referenced
this pull request
Jan 19, 2016
BufferedSink: Remove progress notifications
Member
|
I think we all agree that we want to remove the promise progression API and getting this in is the right thing to do 👍 However, this currently targets the v0.4.4 milestone and dropping this feature ought to be considered a BC break. This means we would have to move this (and all following PRs) to a future v0.5.0 milestone. As such, my vote would be to revert this PR for now so that we get the other changes out. We should reconsider this for the v0.5.0 release. /cc @cboden, @jsor, @WyriHaximus |
Member
Author
|
Oh yes, i wasn't aware this has already been merged. 👍 for reverting. |
This was referenced May 18, 2016
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes triggering progress notifications on the promise returned by BufferedSink.
I always recommend to avoid the progression API of promises (it's underspecified, has subtle problems and has little to do with promises).
If you need to listen on data events, use the ReadableStream directly.